Skip to content

Commit

Permalink
fix: Verify Builds Cross-Compiled Binaries
Browse files Browse the repository at this point in the history
Update the `verify` Makefile target to build cross-compiled binaries.
This ensures the s2i CLI can be released across all supported platforms
at all times. Prevents future regressions of #1204.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
  • Loading branch information
adambkaplan committed Jan 16, 2025
1 parent 0e4fe06 commit 658e409
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@ all build:
build-container:
${CONTAINER_ENGINE} build -t localhost/source-to-image/s2i:${VERSION} .

# Build cross-compiled binaries.
build-cross:
hack/build-cross.sh
.PHONY: build-cross

# Verify if code is properly organized.
#
# Example:
# make verify
verify: build
verify: build-cross
hack/verify-gofmt.sh
hack/verify-deps.sh
hack/verify-bash-completion.sh
Expand Down

0 comments on commit 658e409

Please sign in to comment.