Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UBI8 based base image and builder image #1172

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

sayan-biswas
Copy link
Contributor

Changes:

  • Use UIB8 based base imgae
  • Use go-toolset from UBI8

Currently comet repo exists for rhel-8 based images, so to onboard to konflux easily we'll go ahead with rehl-8 image now. When comet repo for rhel-9 is configured, we'll switch to rehl-9 based images.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
Changes:
- Use UIB8 based base imgae
- Use go-toolset from UBI8

Currently comet repo exists for rhel-8 based images, so to onboard to konflux easily we'll go ahead with rehl-8 image now. When comet repo for rhel-9 is configured, we'll switch to rehl-9 based images.
Copy link
Contributor

openshift-ci bot commented Sep 28, 2024

@sayan-biswas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f68cc16 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sayan-biswas
Copy link
Contributor Author

sayan-biswas commented Sep 28, 2024

/approved

@sayan-biswas
Copy link
Contributor Author

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 28, 2024

@sayan-biswas: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sayan-biswas
Copy link
Contributor Author

/assign @apoorvajagtap

Copy link

@ramessesii2 ramessesii2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
Copy link
Contributor

openshift-ci bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramessesii2, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6799bcc into openshift:master Sep 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants