forked from tektoncd/pipeline
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge extensions into body for webhook interceptors
With CEL interceptor writing to the `extensions` field, it is impossible to chain added fields from a CEL interceptor to a webhook interceptor today. This is because we do not pass the extensions field to the webhook interceptor yet. This commit attempts to fix this by merging any extensions to the body before sending it over to the Webhook interceptor. This is temporary until we fully move webhook interceptors to the new pluggable interface. One implication of this change is that the body may now contain an `extensions` field separate from the top level extensions field if one uses the Webhook interceptor. In addition, the CEL environment also did not have access to extensions which I fixed. Fixes tektoncd#857 Signed-off-by: Dibyo Mukherjee <dibyo@google.com> Add extensions support to CEL
- Loading branch information
1 parent
3ea7d14
commit a079952
Showing
5 changed files
with
257 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters