Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-11928: Build with Go 1.20 (#6126) #106

Merged
merged 2 commits into from
Apr 19, 2023
Merged

OCPBUGS-11928: Build with Go 1.20 (#6126) #106

merged 2 commits into from
Apr 19, 2023

Conversation

jan--f
Copy link

@jan--f jan--f commented Apr 18, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

sylr and others added 2 commits April 18, 2023 16:48
@sylr @jan--f
Build with Go 1.20 (thanos-io#6126)
af10708 
* Build with Go 1.20

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Upgrade codeql workflow

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Upgrade go4.org/unsafe/assume-no-moving-gc

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Update Changelog

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Upgrade golangci-lint

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Sync github workflows

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Fix indentation in documentation code snippet

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Make createBlock chunk size deterministic

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

---------

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com>
(cherry picked from commit 8da34a1)
@jan--f
go mod vendor
e11e6da 
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2023
@openshift-ci-robot
Copy link

@jan--f: This pull request references Jira Issue OCPBUGS-11928, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jan--f
Copy link
Author

jan--f commented Apr 18, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2023
@openshift-ci-robot
Copy link

@jan--f: This pull request references Jira Issue OCPBUGS-11928, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bdd5901 and 2 for PR HEAD e11e6da in total

sthaha
sthaha reviewed Apr 18, 2023
View reviewed changes
Copy link

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier,sthaha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e5ca784 into openshift:master Apr 19, 2023
@openshift-ci-robot
Copy link

@jan--f: Jira Issue OCPBUGS-11928: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11928 has been moved to the MODIFIED state.

In response to this:

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha left review comments

@juzhao juzhao Awaiting requested review from juzhao

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@simonpasquier simonpasquier

@sthaha sthaha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jan--f @openshift-ci-robot @simonpasquier @sthaha @openshift-merge-robot @sylr