Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-12525: fallback Thanos to 0.30.2. #112

Merged
merged 1 commit into from
May 4, 2023

Conversation

raptorsun
Copy link

@raptorsun raptorsun commented Apr 27, 2023

This PR reverts the merge commit 5f96f514a330fce4de1eafa3a25e3281714f12aa that upgrades from version 0.30.2 to 0.31.0.
An issue of deduplication is found in version 0.31.0, so we fallback to version 0.30.2 when looking for a solution to the issue.
Meanwhile, we have deactivated the syncbot workflow for our downstream Thanos repository when waiting for the resolution of the deduplication issue.
Once the issue is resolved, we need to do the following steps:

  1. revert the commit of this PR
  2. activate the syncbot work flow

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2023
@openshift-ci-robot
Copy link

@raptorsun: This pull request references Jira Issue OCPBUGS-12525, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao April 27, 2023 13:29
@openshift-ci-robot
Copy link

@raptorsun: This pull request references Jira Issue OCPBUGS-12525, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

This PR reverts the merge commit 5f96f514a330fce4de1eafa3a25e3281714f12aa that upgrades from version 0.30.2 to 0.31.0.
An issue of deduplication is found in version 0.31.0, so we fallback to version 0.30.2 when looking for a solution to the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2023

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@raptorsun: This pull request references Jira Issue OCPBUGS-12525, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

This PR reverts the merge commit 5f96f514a330fce4de1eafa3a25e3281714f12aa that upgrades from version 0.30.2 to 0.31.0.
An issue of deduplication is found in version 0.31.0, so we fallback to version 0.30.2 when looking for a solution to the issue.
When upgrading Thanos to a newer version than 0.30.2, we need to revert this PR before merging new upstream commits into this repository.
Meanwhile, we need to deactivate syncbot for Thanos repository when waiting for the resolution of the deduplication issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@raptorsun: This pull request references Jira Issue OCPBUGS-12525, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

This PR reverts the merge commit 5f96f514a330fce4de1eafa3a25e3281714f12aa that upgrades from version 0.30.2 to 0.31.0.
An issue of deduplication is found in version 0.31.0, so we fallback to version 0.30.2 when looking for a solution to the issue.
Meanwhile, we have deactivated the syncbot workflow for our downstream Thanos repository when waiting for the resolution of the deduplication issue.
Once the issue is resolved, we need to do the following steps:

  1. revert the commit of this PR
  2. activate the syncbot work flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit baf119a into openshift:master May 4, 2023
@openshift-ci-robot
Copy link

@raptorsun: Jira Issue OCPBUGS-12525: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12525 has been moved to the MODIFIED state.

In response to this:

This PR reverts the merge commit 5f96f514a330fce4de1eafa3a25e3281714f12aa that upgrades from version 0.30.2 to 0.31.0.
An issue of deduplication is found in version 0.31.0, so we fallback to version 0.30.2 when looking for a solution to the issue.
Meanwhile, we have deactivated the syncbot workflow for our downstream Thanos repository when waiting for the resolution of the deduplication issue.
Once the issue is resolved, we need to do the following steps:

  1. revert the commit of this PR
  2. activate the syncbot work flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

machine424 added a commit to machine424/cluster-monitoring-operator that referenced this pull request May 30, 2023
The versions in jsonnet/versions.yaml are only used as metadata (added as Kube labels)
CMO is already using the appropriate versions from downstream.

The thanos downgrade is justified, see openshift/thanos#112
for more details.

Signed-off-by: Ayoub Mrini <amrini@redhat.com>
openshift-merge-robot pushed a commit that referenced this pull request Sep 18, 2023
This reverts commit baf119a, reversing
changes made to 63ce15f.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants