Bug 1873353: bump Thanos to v0.15.0-rc.1 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix swift: fixed missing Content-Type headers issue Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * chore CHANGELOG: add PR id Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * fix swift: fixed invalid lower range boundary Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * fix swift: fixed typo in ENV variable for testing bucket Signed-off-by: Martin Chodur <m.chodur@seznam.cz> Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
* query: e2e: Test --web.external-prefix Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * query: e2e: Test both routePrefix and externalPrefix used simultaneously Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * query: ui: Fix external prefix handling in UI Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * ui: handle web.external-prefix in React UI Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * e2e: query: Fix e2e externalPrefix tests Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Add changelog and regenerated docs Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * query: e2e: close httptest server after test completes Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Make changes according to Giedrius' suggestions Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * ui: Fix react development build erroring out Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Make changes according to Lucas' suggestions Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
It should go under the unreleased section. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
* Created proposal for docs versioning Signed-off-by: thisisobate <obasiuche62@gmail.com> * fix some grammar isssues Signed-off-by: thisisobate <obasiuche62@gmail.com> * Minor typo changes after review Signed-off-by: thisisobate <obasiuche62@gmail.com>
Currently, alert state is rendered as upper case. In Prometheus it is lower case. This fixes it. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
…2848) * correctly marshal errors to JSON and ignore if nil Signed-off-by: Dan Potepa <dan@danpotepa.co.uk> * LastError should be cleared if the newer update was ok Signed-off-by: Dan Potepa <dan@danpotepa.co.uk>
* chore: enable Swift CI tests Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * Update .circleci/config.yml Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Enable godot Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Update contributing guide Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Added by thanos-io#2838. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
…xySeries and MultiTSDB Series benchmarks. (thanos-io#2305) Also: * Fixed minTime for TSDB and Receiver. Now checks head block min Time as well. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
… which was leaking on errors. (thanos-io#2866) * receive: Fixed leak on receive and querier proxying Store API Series, which was leaking on errors. Fixes: thanos-io#2823 TestTenantSeriesSetServert_NotLeakingIfNotExhausted was showing leaks: ``` TestTenantSeriesSetServert_NotLeakingIfNotExhausted/cancelled,_not_exhausted_StoreSet: leaktest.go:132: leaktest: timed out checking goroutines TestTenantSeriesSetServert_NotLeakingIfNotExhausted/cancelled,_not_exhausted_StoreSet: leaktest.go:150: leaktest: leaked goroutine: goroutine 84 [chan send]: github.com/thanos-io/thanos/pkg/store.(*tenantSeriesSetServer).Send(0xc000708360, 0xc0003104c0, 0x0, 0x0) /home/bwplotka/Repos/thanos/pkg/store/multitsdb.go:141 +0x13e github.com/thanos-io/thanos/pkg/store.(*mockedStoreServer).Series(0xc0004e6330, 0xc0007083c0, 0x20ac2c0, 0xc000708360, 0x5116a0, 0x0) /home/bwplotka/Repos/thanos/pkg/store/multitsdb_test.go:173 +0x76 github.com/thanos-io/thanos/pkg/store.(*tenantSeriesSetServer).Series.func1(0x2097760, 0xc00003c940) /home/bwplotka/Repos/thanos/pkg/store/multitsdb.go:121 +0x56 github.com/thanos-io/thanos/pkg/tracing.DoInSpan(0x2097760, 0xc00003c940, 0x1c8bace, 0x17, 0xc000173760, 0x0, 0x0, 0x0) /home/bwplotka/Repos/thanos/pkg/tracing/tracing.go:72 +0xcc github.com/thanos-io/thanos/pkg/store.(*tenantSeriesSetServer).Series(0xc000708360, 0x20983e0, 0xc0004e6330, 0xc0007083c0) /home/bwplotka/Repos/thanos/pkg/store/multitsdb.go:120 +0xfa github.com/thanos-io/thanos/pkg/store.TestTenantSeriesSetServert_NotLeakingIfNotExhausted.func2.1(0xc000708360, 0xc0004e6330) /home/bwplotka/Repos/thanos/pkg/store/multitsdb_test.go:225 +0x62 created by github.com/thanos-io/thanos/pkg/store.TestTenantSeriesSetServert_NotLeakingIfNotExhausted.func2 /home/bwplotka/Repos/thanos/pkg/store/multitsdb_test.go:224 +0x618 --- FAIL: TestTenantSeriesSetServert_NotLeakingIfNotExhausted/cancelled,_not_exhausted_StoreSet (10.03s) FAIL Process finished with exit code 1 ``` TestMultiTSDBStore_NotLeakingOnPrematureFinish was showing: ``` TestMultiTSDBStore_NotLeakingOnSendError: leaktest.go:150: leaktest: leaked goroutine: goroutine 84 [chan send]: github.com/thanos-io/thanos/pkg/store.ctxRespSender.send(...) /home/bwplotka/Repos/thanos/pkg/store/proxy.go:198 github.com/thanos-io/thanos/pkg/store.(*MultiTSDBStore).Series.func1(0x0, 0x0) /home/bwplotka/Repos/thanos/pkg/store/multitsdb.go:214 +0x5cf golang.org/x/sync/errgroup.(*Group).Go.func1(0xc0002708d0, 0xc000416380) /home/bwplotka/Repos/thanosgopath/pkg/mod/golang.org/x/sync@v0.0.0-20200317015054-43a5402ce75a/errgroup/errgroup.go:57 +0x59 created by golang.org/x/sync/errgroup.(*Group).Go /home/bwplotka/Repos/thanosgopath/pkg/mod/golang.org/x/sync@v0.0.0-20200317015054-43a5402ce75a/errgroup/errgroup.go:54 +0x66 --- FAIL: TestMultiTSDBStore_NotLeakingOnSendError (10.02s) ``` Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Quick fix for leaks. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fixed issues found by lint. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Get back copying. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Lint Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* query: Add API endpoints for runtime and build info Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * ui: react: Enable runtime and build info page for Query Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * query: Log error when getting working directory fails Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Fix runtimeInfo being falsely reported Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Add entry in changelog Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Refactor code to use RuntimeInfoFn type Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
…instead of single, big one. (thanos-io#2863) This is to have unified chunk size, and should reduce the load on querier. This also will be much more comparable when chunk iterator will be done. See following benchmark results for Receive (multiTSDB): ``` benchstat -delta-test none _dev/bench_outs/0-receiveseries/benchBenchmarkMultiTSDBSeries.out _dev/bench_outs/1-receiveseries/benchBenchmarkMultiTSDBSeries.out name old time/op new time/op delta MultiTSDBSeries/1000000SeriesWith1Samples/headOnly/4_TSDBs_with_1_samples,_250000_series_each-12 6.41s ± 0% 6.16s ± 0% -3.85% MultiTSDBSeries/1000000SeriesWith1Samples/blocksOnly/4_TSDBs_with_1_samples,_250000_series_each-12 5.77s ± 0% 6.16s ± 0% +6.61% MultiTSDBSeries/100000SeriesWith100Samples/headOnly/4_TSDBs_with_25_samples,_25000_series_each-12 3.68s ± 0% 3.96s ± 0% +7.43% MultiTSDBSeries/100000SeriesWith100Samples/blocksOnly/4_TSDBs_with_25_samples,_25000_series_each-12 4.04s ± 0% 4.02s ± 0% -0.46% MultiTSDBSeries/1SeriesWith10000000Samples/headOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 1.53s ± 0% 1.57s ± 0% +2.08% MultiTSDBSeries/1SeriesWith10000000Samples/blocksOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 1.67s ± 0% 1.66s ± 0% -1.12% name old alloc/op new alloc/op delta MultiTSDBSeries/1000000SeriesWith1Samples/headOnly/4_TSDBs_with_1_samples,_250000_series_each-12 4.08GB ± 0% 4.08GB ± 0% +0.03% MultiTSDBSeries/1000000SeriesWith1Samples/blocksOnly/4_TSDBs_with_1_samples,_250000_series_each-12 4.08GB ± 0% 4.08GB ± 0% -0.01% MultiTSDBSeries/100000SeriesWith100Samples/headOnly/4_TSDBs_with_25_samples,_25000_series_each-12 1.73GB ± 0% 1.72GB ± 0% -0.37% MultiTSDBSeries/100000SeriesWith100Samples/blocksOnly/4_TSDBs_with_25_samples,_25000_series_each-12 1.66GB ± 0% 1.67GB ± 0% +0.57% MultiTSDBSeries/1SeriesWith10000000Samples/headOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 2.71GB ± 0% 2.47GB ± 0% -8.68% MultiTSDBSeries/1SeriesWith10000000Samples/blocksOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 2.68GB ± 0% 2.46GB ± 0% -8.14% name old allocs/op new allocs/op delta MultiTSDBSeries/1000000SeriesWith1Samples/headOnly/4_TSDBs_with_1_samples,_250000_series_each-12 44.9M ± 0% 44.9M ± 0% +0.00% MultiTSDBSeries/1000000SeriesWith1Samples/blocksOnly/4_TSDBs_with_1_samples,_250000_series_each-12 44.9M ± 0% 44.9M ± 0% -0.00% MultiTSDBSeries/100000SeriesWith100Samples/headOnly/4_TSDBs_with_25_samples,_25000_series_each-12 27.1M ± 0% 27.1M ± 0% -0.01% MultiTSDBSeries/100000SeriesWith100Samples/blocksOnly/4_TSDBs_with_25_samples,_25000_series_each-12 27.1M ± 0% 27.1M ± 0% +0.01% MultiTSDBSeries/1SeriesWith10000000Samples/headOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 1.02M ± 0% 1.69M ± 0% +65.15% MultiTSDBSeries/1SeriesWith10000000Samples/blocksOnly/4_TSDBs_with_2500000_samples,_1_series_each-12 1.02M ± 0% 1.69M ± 0% +65.34% ``` Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Detach fanout context from request context Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Remove separate govet run, golangci-lint already does it Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Simplify detached context flow, remove nolints Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
* Introduce replication metric Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add alerts and dashboards for the new replication metric Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Fixes: https://app.circleci.com/pipelines/github/thanos-io/thanos/1545/workflows/851eeb7a-8e4c-4b7e-b7c4-5e63582004a0/jobs/9566/steps Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…hanos-io#2875) max is aggregating across series. We need to aggregate something across time as well as series due to rollout. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Go's `encoding/json` turns nil slices into `null` instead of `[]`. This is problematic for consumers expecting that the `alerts` field is a JSON array. The same is true for empty rule groups. The solution is to enforce that nil slices are converted to zero-length slices when encoding. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Cut release v0.14.0-rc.0 (thanos-io#2826) Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * ci: Manually download promu in crossbuild stage (thanos-io#2828) * Manually download promu in crossbuild stage Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Make sure all directories created in the path Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Cut release v0.14.0-rc.1 (thanos-io#2853) Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Cut release v0.14.0 (thanos-io#2877) Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
…-io#2835) * ui: react: Add a dropdown for selecting max source resolution Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Pre bind onMaxResolutionChange function Signed-off-by: Prem Kumar <prmsrswt@gmail.com> * Return status directly Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
* Updated TSDBs and other dependant deps. This is on TSDB fix: prometheus/prometheus@823b218 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fixed test. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Adding about external_labels in katacoda tutorial Signed-off-by: soniasingla <soniasingla.1812@gmail.com> * Update: Added more information about external_labels Signed-off-by: soniasingla <soniasingla.1812@gmail.com> * Changes updated Signed-off-by: soniasingla <soniasingla.1812@gmail.com> * remove white noise Signed-off-by: soniasingla <soniasingla.1812@gmail.com>
Signed-off-by: John Belmonte <john@neggie.net>
* validate relabel action Signed-off-by: ranjithkumar007 <ranjith.dakshana2015@gmail.com> * move ParseRelabelConfig to pkg/block Signed-off-by: Ranjith Kumar <ranjith.dakshana2015@gmail.com> * fix ci Signed-off-by: Ranjith Kumar <ranjith.dakshana2015@gmail.com>
v0.15.0-rc.1 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
openshift-ci-robot
added
bugzilla/severity-medium
|
@simonpasquier: This pull request references Bugzilla bug 1873353, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/test e2e-aws-upgrade |
|
/hold waiting for the official v0.15 release. |
openshift-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
v0.15.0 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
/lgtm |
|
It said:
/lgtm /shrug |
openshift-ci-robot
added
¯\_(ツ)_/¯
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, s-urbaniak, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@simonpasquier: All pull requests linked via external trackers have merged: Bugzilla bug 1873353 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Side note: Lets also bump kube-thanos in CMO. :) (Sorry if you already did/are doing it) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.