PR builds on boosters do not pass

[sbose78]

https://gist.github.com/anonymous/7c1c32ad5e8b8ca1ba398074575f2fd9

[rawlingsj]

that looks like the integration test.. is that right? If so can you check the resources in the environment that it is running in, I think now that should be your users home namespace.

The error looks like the pod didn't start in time during the integration test but I could be wrong. A bit more info is needed.

[sbose78]

Thanks @rawlingsj for looking into this -
In https://console.starter-us-east-2.openshift.com/console/project/shbose/quota
Resource usage is at 50% for cpu and memory, with 2 out of 5 services.

You are correct, that's the integration test:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Picked up _JAVA_OPTIONS: -Duser.home=/root/ -XX:+UseParallelGC                                 -XX:MinHeapFreeRatio=20                                 -XX:MaxHeapFreeRatio=40                                 -XX:GCTimeRatio=4                                 -XX:AdaptiveSizePolicyWeight=90                                 -Xmx256m
Running io.openshift.booster.OpenShiftIT
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
application deployed, 3 object(s) created.
Route url: http://booster-rest-http-vertx-shbose.8a09.starter-us-east-2.openshiftapps.com
Deleting application : DeploymentConfig
Tests run: 2, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 306.268 sec <<< FAILURE! - in io.openshift.booster.OpenShiftIT
testThatWeAreReady(io.openshift.booster.OpenShiftIT)  Time elapsed: 300.032 sec  <<< ERROR!
com.jayway.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.openshift.booster.test.OpenShiftTestAssistant was not fulfilled within 5 minutes.
	at com.jayway.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:122)
	at com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:79)
	at com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:27)
	at com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:764)
	at com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:741)
	at io.openshift.booster.test.OpenShiftTestAssistant.awaitApplicationReadinessOrFail(OpenShiftTestAssistant.java:141)
	at io.openshift.booster.OpenShiftIT.testThatWeAreReady(OpenShiftIT.java:39)

testThatWeServeAsExpected(io.openshift.booster.OpenShiftIT)  Time elapsed: 2.838 sec  <<< FAILURE!

[bartoszmajsak]

This might be fixed with fabric8io/fabric8-pipeline-library#381

@sbose78 give it a spin when merged or use @Library('github.com/bartoszmajsak/fabric8-pipeline-library@cube-properties') as that's what this PR brings.

[piyush-garg]

@sbose78 Is this still happening? Can you confirm please?

[hrishin]

PR build is failing for Integration Tests

1. vertex app build logs:
   https://pastebin.com/N2X5YMEF

2. Springboot app build logs:
   https://pastebin.com/sD7TPwfZ

[piyush-garg]

@sthaha This is an issue which is reproducible in the current state also.

[bartoszmajsak]

Another issue leading to that problem (reproducible if you have Configmap booster imported) #3134 (comment)

[bartoszmajsak]

I managed to fix my issue and I see that reports from @hrishin are showing the same symptoms #763 (comment). I'm happy to provide a PR to the pipeline library based on the outcome of the discussion here #3134 (comment)

[piyush-garg]

Fixed with fabric8io/fabric8-jenkinsfile-library#37

[bartoszmajsak]

@piyush1594 did we run PR builds to verify that? Can you point me to the booster repos?

[piyush-garg]

@bartoszmajsak I tested @hrishin PR fabric8io/fabric8-jenkinsfile-library#36 using my repo https://github.com/piyush1594/test-ci-maven