Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DS1820 driver #1382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve DS1820 driver #1382

wants to merge 3 commits into from

Commits on Oct 7, 2024

  1. feat: Improve DS1820 driver 

    New features:
* Handle all types of DS1820 tempature sensors by detecting the family of the sensor and calculating the temperature accordingly
* Clean up some log prints
* Set the channel value with current temperature
* Set the period of the conversion interval with an optional first parameter
* Start the conversion instantly and not wait for multiple of the conversion period
    @Lenart12
    Lenart12 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e4ae0a7 View commit details
    Browse the repository at this point in the history

  2. rework: Change DS1820 logging to be more consistent 

    - Output logging to `LOG_FEATURE_SENSOR` and not `CFG` as it would be expected
- Created a macro `DS1820_LOG` to simplify logging statements.
- Use the macro in various places throughout the driver
    @Lenart12
    Lenart12 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b3abaa6 View commit details
    Browse the repository at this point in the history

  3. refactor: Remove unused crc code and improve DS1820 logging 

    Co-authored-by: MaxineMuster <146550015+MaxineMuster@users.noreply.github.com>
    @Lenart12 @MaxineMuster
    Lenart12 and MaxineMuster committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f9f66cc View commit details
    Browse the repository at this point in the history