Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify configure script to handle API distribution. #3959

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Nov 5, 2024

Fixes issue #0

Brief summary of changes

This PR is supposed to generate the correct configure script to decide if API or GUI distribution and either way sets the required paths in Matlab.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

@aymanhab
Copy link
Member Author

aymanhab commented Nov 5, 2024

@mattpetrucci Thanks for the reminder. Once the build completes I'll test the resulting script of the artifact on windows and will tag you to test in Mac environment. There will be both Arm64 and X86 artifacts on osx.

@aymanhab
Copy link
Member Author

@mattpetrucci The configure script here should handle API distribution. Please let me know if you run into problem using it. Thank you.

@mattpetrucci
Copy link

@aymanhab Looks like it configured, but when I restart and tested with model = org.opensim.modeling.Model() I get errors for the dynamic libraries (see attached images). I'm on MacOS Sequoia now, and things have been more locked down in terms of permissions. This was with the CI artifact from 11-25. You had shared 11-05 originally in this thread, but I assume they have the same configure script?

@nickbianco tagging you to loop you in to where I've left off.

Screenshot 2024-12-11 at 2 02 19 PM Screenshot 2024-12-11 at 2 02 07 PM Screenshot 2024-12-11 at 2 01 42 PM

@nickbianco
Copy link
Member

@mattpetrucci you might be able to manually remove the quarantine status of downloaded files on Mac using xattr -d com.apple.quarantine my_file. I haven't tried this on Sequoia yet though. You could it for just that first file, i.e., xattr -d com.apple.quarantine libosimJavaJNI.dylib and see if that works (you'll probably get a pop up for another file, but that's expected since you will have only stripped the quarantine attribute from the first file).

@mattpetrucci
Copy link

Thanks @nickbianco, that worked to get past the first but as you said, the others start popping up. Can I xattr a whole directory?

@nickbianco
Copy link
Member

You might be able to add the flag -r to dequarantine a directory:

xattr -dr com.apple.quarantine ~/my_dir

@mattpetrucci
Copy link

Awesome, that worked. I just de-quarantined the whole artifact folder. No errors.

Screenshot 2024-12-11 at 4 44 12 PM

@aymanhab
Copy link
Member Author

Sounds great @mattpetrucci and thanks for the pointer @nickbianco

Any reason not to merge then?

@mattpetrucci
Copy link

Maybe we merge and just update the documentation (if needed) to do the de-quarantine?

@nickbianco nickbianco self-requested a review December 12, 2024 17:12
Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nickbianco nickbianco merged commit 00387c7 into main Dec 12, 2024
12 checks passed
@nickbianco nickbianco deleted the configure_matlab_from_api_distro branch December 12, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants