Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests with pyzmq 17 #305

Closed
wants to merge 3 commits into from

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jul 30, 2018

libzmq 4.2, which is bundled with pyzmq 17 but can be used with ~any version of pyzmq, does not cleanup ipc files after closing sockets. The fix is to cleanup these files after closing the binding socket.

closes #303

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #305 into master will decrease coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   99.19%   98.52%   -0.67%     
==========================================
  Files          26       26              
  Lines        3588     3597       +9     
  Branches      257      259       +2     
==========================================
- Hits         3559     3544      -15     
- Misses         16       34      +18     
- Partials       13       19       +6
Impacted Files Coverage Δ
osbrain/agent.py 98.03% <100%> (-0.11%) ⬇️
osbrain/__init__.py 88.88% <0%> (-11.12%) ⬇️
osbrain/tests/test_helper.py 93.85% <0%> (-6.15%) ⬇️
osbrain/helper.py 94.87% <0%> (-5.13%) ⬇️
osbrain/tests/test_timer.py 96.6% <0%> (-2.43%) ⬇️
osbrain/nameserver.py 97.65% <0%> (-1.57%) ⬇️
osbrain/tests/test_nameserver.py 97.64% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781e26d...11a216c. Read the comment docs.

@Peque Peque added this to the 0.7.0 milestone Jul 30, 2018
@Peque
Copy link
Member

Peque commented Jul 30, 2018

Thanks for this PR and for finding the issue with current ZMQ not unlinking those files. It is unfortunate but we definitely need to fix that on our side then.

I will review your changes and fix the remaining issues with CI. You have helped enough already! 😊

@Peque
Copy link
Member

Peque commented Aug 31, 2018

Closed in vafour of #307.

@minrk Your commits where squashed but you kept the authorship: afd59ac

Thanks for your help! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyZMQ to version 17
2 participants