Make sure test can run on windows #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,11 +186,13 @@ void testJvmMemory() { | |||
| } | |||
|
|
|||
| @Test | |||
| @DisabledOnOs(WINDOWS) | |||
| void linuxDiskReadBytes() { | |||
There was a problem hiding this comment.
這個測試在mac作業系統也跑不過，請問是否考慮改成使用@EnabledOnOs？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
為了照顧windows使用者，因此這隻PR disable無法在windows上執行的tests，不過下列幾隻我不太確定為何不能在windows跑，因此會另外開議題來追蹤
ReplicaCollieTestReplicaCollieTest can't run on windows #102TopicAdminTest#testReassignTopicAdminTest#testReassign can't run on windows #103