Enable RebalancePlanExecutor to execute plan with/without sycn waiting #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
commented
Nov 1, 2022
| addingReplicas -> { | ||
| if (addingReplicas.isEmpty()) | ||
| return RebalancePlanExecutor.of() | ||
| .execute(context.admin(), ClusterInfo.of(replicas), Duration.ofHours(1)) |
There was a problem hiding this comment.
調整成等候 re-election，看看是否有其他回饋
chia7712
commented
Nov 1, 2022
|
|
||
| checkbox.setDisable(true); |
There was a problem hiding this comment.
對應可能等很久的調整，不讓使用者做進一步操作
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1055
現在
RebalancePlanExecutor預設需要實作的部分只要完成搬移就好，最後集體的資料同步和re-election將會由預設實作完成。同時使用者可以選擇是否要等待最後的同步