Revise RebalancePlanGenerator to AllocationTweaker
#1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 2, 2022
common/src/main/java/org/astraea/common/balancer/generator/ShuffleTweaker.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個 PR 把
RebalancePlanGenerator的名字改掉，改成AllocationTweaker。這個物件原先的責任是產生出計劃，但是現在這個責任已經被
Balancer物件的實作取代。這個物件現在專注在如何對一個ClusterLogAllocation進行調整（在 solution space 中走一步）。由於這個物件的名稱已經和他現在的責任不太一樣，為了避免造成誤會所以幫他改名。幾個重大的改變：
AllocationTweaker#generate現在直接回傳ClusterLogAllocationstep結果自 WebAPI 移除RebalancePlanProposal