Expose internal statistics of GreedyBalancer via JMX
#1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyparrot
commented
Nov 8, 2022
common/src/main/java/org/astraea/common/balancer/algorithms/GreedyBalancer.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 8, 2022
There was a problem hiding this comment.
@garyparrot 感謝實作這個方便的功能
@chaohengstudent 也麻煩看一下，之後Sensor 要能跟 JmX結合
common/src/main/java/org/astraea/common/balancer/algorithms/GreedyBalancer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/balancer/algorithms/GreedyBalancer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/balancer/algorithms/GreedyBalancer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/metrics/jmx/DynamicMbean.java
Outdated
Show resolved
Hide resolved
|
Failed test traced at #1096. |
|
Failed test traced at #1096. |
chia7712
reviewed
Nov 9, 2022
common/src/main/java/org/astraea/common/metrics/jmx/MBeanRegister.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/metrics/jmx/MBeanRegister.java
Outdated
Show resolved
Hide resolved
| BeanQuery.builder().domainName(domainName).property("id", id).build()); | ||
|
|
||
| // register | ||
| MBeanRegister.local() |
There was a problem hiding this comment.
麻煩試著用MBeanClient把剛剛註冊的資訊撈回來比對一下內容
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context: #1084
Previous Discussion: #1089 (comment)
This PR does the following:
DynamicMbeanto ease the process of publishing an MBean on the local JVM.GreedyBalancer. Currently, support theiterationcounter andminCostgauge.