[BACKUP] define RecordWriter interface #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 12, 2022
common/src/main/java/org/astraea/common/backup/RecordWriter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 15, 2022
common/src/main/java/org/astraea/common/backup/RecordWriter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 15, 2022
common/src/main/java/org/astraea/common/backup/RecordWriter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 15, 2022
common/src/main/java/org/astraea/common/backup/LocalFileWriterBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 18, 2022
common/src/main/java/org/astraea/common/backup/LocalFileWriterBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 18, 2022
common/src/main/java/org/astraea/common/backup/LocalFileWriterBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 18, 2022
common/src/main/java/org/astraea/common/backup/FileWriterBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/backup/FileWriterBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/backup/FileWriterBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/backup/FileWriterBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 19, 2022
common/src/main/java/org/astraea/common/backup/RecordWriterBuilder.java
Outdated
Show resolved
Hide resolved
Haser0305
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1093
目前先定義寫入資料的部分，上面的幾個都會使用到最後一個write，沒用到的參數都會帶入null，現在想到是使用 batch 來包數個 record，如果大小達到上限就會寫入到硬碟。
還有在考慮分兩個 thread，一個包裝 batch，另外一個是寫入準備好的 batch。
GC 部分目前在看怎麼操作會比較恰當，目前可能的作法應該會是要一大塊空間來暫時放置 batch 等待寫入
另外有在想 protocol 的部分有無需要額外建立一個 interface 來定義內容