Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETL tool: start script #1130

Merged
merged 27 commits into from
Dec 4, 2022
Merged

ETL tool: start script #1130

merged 27 commits into from
Dec 4, 2022

Conversation

wycccccc
Copy link
Collaborator

TODO

chia7712
chia7712 reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wycccccc 感謝這隻patch，感覺離測試又近了一點，幾個建議請看一下

@wycccccc
Copy link
Collaborator Author

學長它還動不了，我發上來是爲了pull image來測試的，等可以review我再@學長

@wycccccc
Copy link
Collaborator Author

@chia7712 學長它動起來了。可以review了

@wycccccc
Copy link
Collaborator Author

已添加shadow plugin 功能，再麻煩學長繼續review。

@chia7712
Copy link
Contributor

已添加shadow plugin 功能，再麻煩學長繼續review。

我剛剛合併了 #1153 麻煩你先 rebase code

@wycccccc
Copy link
Collaborator Author

我之前的commit就已經rebase了，現在看上去不需要rebase

chia7712
chia7712 reviewed Nov 21, 2022
View reviewed changes
@wycccccc
Copy link
Collaborator Author

好 上述問題已更新 再麻煩學長繼續review

chia7712
chia7712 reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wycccccc 可否仿照start_broker.sh等腳本撰寫一下使用文件？

@wycccccc
Copy link
Collaborator Author

我保留了本地測試和遠端拉取兩種功能。通過配置BY_LOCAL來改變。

可否仿照start_broker.sh等腳本撰寫一下使用文件？

我再另開一隻pr處理，會在這支meger後發出。

@wycccccc
Copy link
Collaborator Author

學長這支也可以review了

chia7712
chia7712 reviewed Nov 28, 2022
View reviewed changes
chia7712
chia7712 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wycccccc wycccccc merged commit c5a4c1f into opensource4you:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wycccccc @chia7712