Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrator interface #115

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Conversation

chia7712
Copy link
Contributor

考量我們要完整支援partition assignments,因此將該操作的設定獨立成一個介面(migrator)以便可擴充支援所有行為

@chia7712 chia7712 requested a review from qoo332001 November 21, 2021 08:33
@chia7712 chia7712 self-assigned this Nov 21, 2021
*
* @param brokers to host partitions
*/
void moveTo(Set<Integer> brokers);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 麻煩在#114新增一個類似這個方法,例如:

void moveTo(Map<Integer, String> brokerFolders)

上述代表要將partitions移到指定的broker和資料路徑

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 那我 #114 那支要等你這支PR merge進去之後在更改嗎?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@chia7712 chia7712 merged commit c8e75cf into opensource4you:main Nov 21, 2021
@chia7712 chia7712 deleted the add_migrator branch December 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants