astraea-974 Implement ReassignmentHandler post request #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[JSON][WEB] Implement ReassignmentHandler post request by Jackson
…gnment # Conflicts: # common/src/main/java/org/astraea/common/Utils.java
chia7712
reviewed
Nov 28, 2022
| request.value(TO_KEY))) | ||
| plan.topic.get(), plan.partition.get(), plan.broker.get()), | ||
| JsonConverter.defaultConverter() | ||
| .convert(plan.to.get(), TypeRef.of(String.class)))) |
There was a problem hiding this comment.
這邊也是跟TopicHandler的狀況類似，當時 APIs 設計時放了類似的格式，這個一來不容易閱讀、二來也造成程式碼的複雜。建議這邊一樣處理掉這個議題，有三種搬移：
- 從 A 節點到 B節點
- 從節點的A目錄到節點的B目錄
- 將某節點身上的 topic partition 通通移開
可以將這幾種種操作的做料分開，例如分別叫做toNodes, toFolders, excludeNodes
|
麻煩rebase一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JSON][WEB] Implement ReassignmentHandler post request by Jackson
ref #974