astraea-974 Implement BalancerHandler post request #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[JSON][WEB] Implement BalancerHandler post request by Jackson
chia7712
reviewed
Nov 28, 2022
# Conflicts: # app/src/main/java/org/astraea/app/web/BalancerHandler.java
chia7712
reviewed
Dec 8, 2022
| public void setBalancer(String balancer) { | ||
| this.balancer = balancer; | ||
| } | ||
|
|
||
| public void setBalancerConfig(Map<String, String> balancerConfig) { |
There was a problem hiding this comment.
這個只有測試使用，我們可否簡化一下程式碼，把setter都移除，讓測試端直接操作內部member就好？
There was a problem hiding this comment.
這個我在下一隻PR處理好了，整體看起來不錯了，我先合併
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JSON][WEB] Implement BalancerHandler post request by Jackson
ref #974