Replace ClusterLogAllocation usage by ClusterInfoBuilder
#1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 29, 2022
chia7712
previously approved these changes
Nov 29, 2022
chia7712
reviewed
Nov 30, 2022
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
|
@chia7712 已修正所有項目，麻煩再看看，感謝 |
chia7712
previously approved these changes
Dec 1, 2022
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1157.
Previous related PR #1165.
這個 PR 根據 #1165 實作出來的
ClusterInfoBuilder，在上面添加兩個函數，分別用來 reassign replica 和 change preferred leader，這些功能將會取代ClusterLogAllocation。ClusterInfoBuilder#reassignReplicaClusterInfoBuilder#setPreferredLeaderClusterLogAllocationAllocationTweaker現在接受和回傳ClusterInfo<Replica>，內部用ClusterInfoBuilder來修改ClusterInfo