spark2kafka process blank line #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
一樣預設跳過，但也要有參數可以改成拋出錯誤 |
|
爲了應對以後可能增加的command line，我將scala的command line加了回來。 |
chia7712
reviewed
Dec 9, 2022
chia7712
reviewed
Dec 10, 2022
chia7712
reviewed
Dec 10, 2022
|
現在改用最單純的方式處理處理blankline，並且移除了對pk non-nullable的判斷 |
chia7712
reviewed
Dec 14, 2022
|
@wycccccc 整體看起來還ok，可否麻煩你手動驗證一下空白行的部分？如果沒問題的話就可以合併 |
沒有問題，它有正確忽略 |
chia7712
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在做測試的時候同樣遇到了blank line的問題。
想確認一下是默認將blankline處理掉，還是要新增一個參數讓用戶決定blankline的合法性