[CONNECTOR] add FtpSinkConnector #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
麻煩rebase一下 |
chia7712
reviewed
Dec 8, 2022
chia7712
reviewed
Dec 9, 2022
chia7712
reviewed
Dec 9, 2022
|
|
|
我認為應該是這邊有改到東西造成的，我再研究看看 |
改好了，主要是因為當初沒有把 working directory 變更回去的關係。 |
chia7712
reviewed
Dec 11, 2022
wycccccc
pushed a commit
to wycccccc/astraea
that referenced
this pull request
Dec 14, 2022
also modify the approach to determine type of a path.
wycccccc
pushed a commit
to wycccccc/astraea
that referenced
this pull request
Dec 14, 2022
also modify the approach to determine type of a path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1188
目前這邊是有測試過可以執行的 ftp sink connector，但應該還會再修改 connector 對於 configuration 的部份。
RecordWriterBuilder#close 那邊因為當初沒有把 outputStream 關閉，因此會導致 ftpClient 連線數太多，開不了新的 outputStream。
FtpFileSystem#type 改了判斷 file 與 nonexistent，如果今天那個 path 為不存在的項目，基於不同的 ftp server 可能會有不同的回傳值，例如 apache mina 會回傳 null，但是 vsftpd server 通常會回傳以下的訊息，因此有增加依照字數來做判斷。