-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement sensors in ReplicaSizeCost #1241
Merged
qoo332001
merged 9 commits into
opensource4you:main
from
qoo332001:ReplicaSizeCost_with_Sensor
Dec 16, 2022
Merged
implement sensors in ReplicaSizeCost #1241
qoo332001
merged 9 commits into
opensource4you:main
from
qoo332001:ReplicaSizeCost_with_Sensor
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Dec 9, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
@qoo332001 記得rebase |
chia7712
reviewed
Dec 11, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 11, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 11, 2022
…icaSizeCost_with_Sensor
chia7712
reviewed
Dec 12, 2022
chia7712
reviewed
Dec 12, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 12, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 12, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 12, 2022
chia7712
reviewed
Dec 13, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 13, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 14, 2022
common/src/main/java/org/astraea/common/cost/ReplicaSizeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 14, 2022
chia7712
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更新
ReplicaSizeCost
,並且實做sensors(),現在計算BrokerCost
與ClusterCost
已經透過用指數移動平均(exponential moving average)統計replica log size來計算分數了