Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONNECTOR] Add exporter definition #1346

Merged
merged 7 commits into from
Dec 27, 2022

Conversation

Haser0305
Copy link
Collaborator

#1297
#1299

有為sink connector 參數增添說明,並且把必要參數需求在init就先確認過,在缺失參數時以提早報錯。 關於time參數應該會在之後的針對時間刷新檔案的時候一併增加。

chia7712
chia7712 previously approved these changes Dec 26, 2022
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

static Definition PASSWORD_KEY =
Definition.builder()
.name("fs.ftp.password")
.type(Definition.Type.STRING)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個應該用PASSWORD

@chia7712 chia7712 merged commit 476a440 into opensource4you:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants