-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONNECTOR] Add exporter definition #1346
Merged
chia7712
merged 7 commits into
opensource4you:main
from
Haser0305:add_exporter_definition
Dec 27, 2022
Merged
[CONNECTOR] Add exporter definition #1346
chia7712
merged 7 commits into
opensource4you:main
from
Haser0305:add_exporter_definition
Dec 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Dec 26, 2022
connector/src/main/java/org/astraea/connector/backup/Exporter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 26, 2022
connector/src/main/java/org/astraea/connector/backup/Exporter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 26, 2022
connector/src/main/java/org/astraea/connector/backup/Exporter.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Dec 26, 2022
connector/src/main/java/org/astraea/connector/backup/Exporter.java
Outdated
Show resolved
Hide resolved
chia7712
previously approved these changes
Dec 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chia7712
reviewed
Dec 26, 2022
static Definition PASSWORD_KEY = | ||
Definition.builder() | ||
.name("fs.ftp.password") | ||
.type(Definition.Type.STRING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這個應該用PASSWORD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1297
#1299
有為sink connector 參數增添說明,並且把必要參數需求在init就先確認過,在缺失參數時以提早報錯。 關於time參數應該會在之後的針對時間刷新檔案的時候一併增加。