Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONNECTOR] apply required flag to Exporter definition #1350

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

chia7712
Copy link
Contributor

套用required,這樣我們就不需要手動檢查

@@ -66,6 +68,7 @@ public class Exporter extends SinkConnector {
.name("path")
.type(Definition.Type.STRING)
.documentation("the path required for file storage.")
.required()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haser0305 @chaohengstudent 麻煩看一下這個用法,Importer definition 也要參考這個手法去設計

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@chia7712 chia7712 merged commit f8f417d into opensource4you:main Dec 27, 2022
@chia7712 chia7712 deleted the apply_required_to_exporter branch December 28, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants