Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL] use RESOURCES_CONFIGS instead of HEAP_OPTS #1362

Merged
merged 1 commit into from
Dec 28, 2022
Merged

[ETL] use RESOURCES_CONFIGS instead of HEAP_OPTS #1362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions docker/start_etl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,21 @@ source "$DOCKER_FOLDER"/docker_build_common.sh
declare -r SPARK_VERSION=${SPARK_VERSION:-3.3.1}
# ===============================[global variables]================================
declare -r LOCAL_PATH=$(cd -- "$(dirname -- "${DOCKER_FOLDER}")" &>/dev/null && pwd)
declare -r HEAP_OPTS="${HEAP_OPTS:-"-Xmx4G -Xms4G"}"
# ===============================[properties keys]=================================
declare -r SOURCE_KEY="source.path"
# ===============================[spark driver/executor resource]==================
declare -r RESOURCES_CONFIGS="${RESOURCES_CONFIGS:-"2G"}"
declare -r RESOURCES_CONFIGS="${RESOURCES_CONFIGS:-"--conf spark.driver.memory=4g --conf spark.executor.memory=4g"}"
# ===================================[functions]===================================

function showHelp() {
echo "Usage: [ENV] start_etl.sh properties_path"
echo "required Arguments: "
echo " master where to submit spark job"
echo " property.file The path of Spark2Kafka.properties."
echo " master where to submit spark job"
echo " property.file The path of Spark2Kafka.properties."
echo "ENV: "
echo " ACCOUNT=skiptests set the account to clone from"
echo " VERSION=main set branch of astraea"
echo " HEAP_OPTS=\"-Xmx2G -Xms2G\" set broker JVM memory"
echo " RESOURCES_CONFIGS=\"-Xmx2G -Xms2G\" set spark memory"
echo " ACCOUNT=skiptests set the account to clone from"
echo " VERSION=main set branch of astraea"
echo " RESOURCES_CONFIGS=\"--conf spark.driver.memory=4g\" set spark memory"
}

function runContainer() {
Expand Down Expand Up @@ -92,8 +90,8 @@ function runContainer() {
ghcr.io/skiptests/astraea/spark:$SPARK_VERSION \
./bin/spark-submit \
--conf "spark.ui.port=$ui_port" \
$RESOURCES_CONFIGS \
--packages org.apache.spark:spark-sql-kafka-0-10_2.13:"$SPARK_VERSION" \
--executor-memory "$RESOURCES_CONFIGS" \
--class org.astraea.etl.Spark2Kafka \
--jars file:///tmp/astraea-etl.jar \
--master $master \
Expand Down