[DISPATCHER] Maintenance of smooth weight round robin #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jan 7, 2023
| this.roundRobinLease = roundRobinLease; | ||
| } | ||
|
|
||
| public static PreArrangementSmoothRR of(int preLength, Duration roundRobinLease) { |
There was a problem hiding this comment.
這個類別不錯，將統一的邏輯拉出來
這邊可以改成 package-private
| var ids = | ||
| clusterInfo.nodes().stream().map(NodeInfo::id).collect(Collectors.toUnmodifiableSet()); | ||
| // TODO: make ROUND_ROBIN_LENGTH configurable ??? | ||
| IntStream.range(0, preLength) |
There was a problem hiding this comment.
preLength可以用roundRobin.length取代
| return new PreArrangementSmoothRR(preLength, roundRobinLease); | ||
| } | ||
|
|
||
| synchronized void tryToUpdateRoundRobin( |
There was a problem hiding this comment.
tryToUpdate就好，因為這隻類別已經知道是RR了
| import org.astraea.common.admin.NodeInfo; | ||
| import org.astraea.common.admin.ReplicaInfo; | ||
|
|
||
| public class PreArrangementSmoothRR { |
| @@ -42,6 +42,30 @@ static <E> RoundRobin<E> smooth(Map<E, Double> scores) { | |||
| */ | |||
| Optional<E> next(Set<E> availableTargets); | |||
|
|
|||
| /** | |||
| * Given initial key-score pair, it will output a preferred key with the highest current weight. | |||
| }); | ||
| } | ||
|
|
||
| private double standardDeviationImperative(double avgMetrics, Map<E, Double> metrics) { |
chia7712
changed the title
|
@wycccccc 標題現在要加上一些簡單的分類，到時候合併的時候請注意一下 |
好，之後會注意
瞭解，我再持續關注 上述問題都已處理完畢，再麻煩review。 |
|
@wycccccc 抱歉，又有一些衝突，可否在麻煩處理一下。等你這次處理完我們先完成這個 PR 再進行後續的修改 |
衝突已經修復，有問題我再及時處理，爭取今日睡前可以merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1086
#1386
as titile， 這支pr一共做了如下幾件事：