Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMMON] Implementation of ClusterInfo#topics #1494

Merged

Conversation

garyparrot
Copy link
Collaborator

Context: #1393

ClusterInfo 攜帶 Topic-level 的設定資訊,未來 DataDirSpaceUsageCost 會需要 retention/compaction 相關的設定來協助判斷各個 partition 對儲存空間的需求。

@garyparrot garyparrot self-assigned this Feb 12, 2023
@garyparrot garyparrot changed the title [COMMON] Implementation of Admin#topicConfigs [COMMON] Implementation of Admin#topics Feb 12, 2023
@garyparrot garyparrot changed the title [COMMON] Implementation of Admin#topics [COMMON] Implementation of ClusterInfo#topics Feb 12, 2023
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyparrot 感謝這個條整,整體看起來很棒,把測試補一補就可以合併了

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 做得很好

@garyparrot garyparrot merged commit 354ba8a into opensource4you:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants