-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COMMON] Implementation of ClusterInfo#topics
#1494
Merged
garyparrot
merged 6 commits into
opensource4you:main
from
garyparrot:cluster-info-with-topic-config
Feb 16, 2023
Merged
[COMMON] Implementation of ClusterInfo#topics
#1494
garyparrot
merged 6 commits into
opensource4you:main
from
garyparrot:cluster-info-with-topic-config
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Feb 12, 2023
garyparrot
changed the title
[COMMON] Implementation of
[COMMON] Implementation of Feb 12, 2023
Admin#topicConfigs
Admin#topics
garyparrot
changed the title
[COMMON] Implementation of
[COMMON] Implementation of Feb 12, 2023
Admin#topics
ClusterInfo#topics
chia7712
reviewed
Feb 12, 2023
chia7712
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garyparrot 感謝這個條整,整體看起來很棒,把測試補一補就可以合併了
chia7712
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 做得很好
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1393
讓
ClusterInfo
攜帶 Topic-level 的設定資訊,未來DataDirSpaceUsageCost
會需要 retention/compaction 相關的設定來協助判斷各個 partition 對儲存空間的需求。