Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The receiver should keep independent objects #154

Merged
merged 2 commits into from
Dec 17, 2021
Merged

The receiver should keep independent objects #154

merged 2 commits into from
Dec 17, 2021

Conversation

chia7712
Copy link
Contributor

from #138 (comment)

現在不同的receiver會維護各自的objects，而非跟其他receivers共用

@chia7712 chia7712 self-assigned this Dec 17, 2021
@chia7712 chia7712 mentioned this pull request Dec 17, 2021
Merged
@chia7712 chia7712 requested a review from wycccccc December 17, 2021 08:12
wycccccc
wycccccc approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@wycccccc wycccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝更新，這樣設計應該就沒問題了，我再進行測試，LGTM。

@chia7712 chia7712 merged commit 97d2f46 into opensource4you:main Dec 17, 2021
@chia7712 chia7712 deleted the different_receivers branch December 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wycccccc wycccccc wycccccc approved these changes

Assignees

@chia7712 chia7712

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chia7712 @wycccccc