Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency benchmark #16

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Conversation

chia7712
Copy link
Contributor

@chia7712 chia7712 commented Sep 11, 2021

@chia7712 chia7712 self-assigned this Sep 11, 2021
@chia7712
Copy link
Contributor Author

@chinghongfang 我這邊有一些業務需求,因此先做一個版本來測試latency。理想上之後你的#11可以取代這隻暫時的benchmark.

import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.producer.ProducerConfig;

interface ComponentFactory {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinghongfang 麻煩參考看看,這邊示範一個方式如何抽象實作,讓我們方便寫unit test驗證自身邏輯又可以不用真的使用kafka

@chinghongfang
Copy link
Collaborator

@chia7712 好的,我會盡快修改的,目前正在學習撰寫unit test,會儘快趕上的,讓學長等久了。

@chia7712 chia7712 merged commit 27da8ae into opensource4you:main Sep 12, 2021
Copy link
Collaborator

@chinghongfang chinghongfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch. It helps me a lot.

@chia7712 chia7712 deleted the latency_benchmark branch December 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants