-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partitionScore #182
Fix partitionScore #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 感謝修正,有蠻多地方可以用lambda重寫,麻煩看一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 不好意思,太晚看這隻PR
幾個小問題麻煩處理一下,另外請手動測試一下,並貼上改正後的畫面
謝謝
原本只能讀到partition的leader,更新後已可以使用broker中所有的replica來計算分數
忽略internal topics:
|
現在的畫面還不錯,不過我在想是否有機會更延伸一點讓我們的算分程式輸出更有"linux"的味道,#240 接著討論 |
這支PR修正了 partitionScore讀不到 internel topics的問題,以及新增argument,使其可以決定是否要在計算分數時忽略internel topics,以及是否要輸出已經balance之Βroker