Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky PerformanceTest #196

Merged
merged 3 commits into from
Jan 23, 2022
Merged

fix flaky PerformanceTest #196

merged 3 commits into from
Jan 23, 2022

Conversation

wycccccc
Copy link
Collaborator

@wycccccc wycccccc commented Jan 22, 2022 •
edited
Loading

#195 該bug的產生原因為adminClient可能會存在還沒有來得及創建topic,之後的程序就需要抓topic了，所以這裡給它一個等待的時間。

@wycccccc wycccccc requested a review from chia7712 January 22, 2022 17:21
chia7712
chia7712 reviewed Jan 22, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use “until” function to make sure the state gets stable?

@wycccccc
Copy link
Collaborator Author

ok 它跑了100多遍沒有報錯，我想它現在正常了。
Screenshot from 2022-01-23 16-56-16

@chia7712
Copy link
Contributor

@wycccccc please take a look at comment

#196 (review)

@wycccccc
Copy link
Collaborator Author

OK,I think it should be right now.

chia7712
chia7712 approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chia7712 chia7712 merged commit 6a0ae5a into opensource4you:main Jan 23, 2022
@wycccccc wycccccc mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wycccccc @chia7712