Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consumerDone() false when no consumer #212

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix consumerDone() false when no consumer #212

merged 2 commits into from
Feb 8, 2022

Conversation

chinghongfang
Copy link
Collaborator

#209

Manager#consumedDone is always false when there is no consumer ...

Fixed by adding check on number of consumers.

@chinghongfang
Add unit test for Manager#consumerDone
192f0fd 
Also unit test for `Manager#producerDone()`.
chia7712
chia7712 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@chia7712
Copy link
Contributor

chia7712 commented Feb 8, 2022

@chinghongfang 麻煩你自己合併一下喔

@chinghongfang chinghongfang merged commit 982af3e into opensource4you:main Feb 8, 2022
@chinghongfang chinghongfang deleted the fixBug branch March 2, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinghongfang @chia7712