Offset explorer - used to expose the earliest offset and latest offset for topics #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
requested review from
chinghongfang,
garyparrot,
wycccccc and
qoo332001
garyparrot
approved these changes
Sep 26, 2021
Comment on lines
93
to
98
| private static String help() { | ||
| return BROKERS_KEY | ||
| + "REQUIRED: The server to connect to" | ||
| + TOPIC_KEY | ||
| + " OPTIONAL: the topic to check"; | ||
| } |
There was a problem hiding this comment.
可能不是很重要的改變，不過 Help 的內容或許排版一下
--bootstrap.serversREQUIRED: The server to connect to--topic OPTIONAL: the topic to check
不過這真的不影響功能就是了，或許能改天某個熱心人士送 PR 修好一點
There was a problem hiding this comment.
你說得對。我們應該要有一個統一的格式化排版給我們寫的所有tools，這樣可以一致又好看。
我會開個議題紀錄一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see
READMEfor usage.