Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove smooth weight #301

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

wycccccc
Copy link
Collaborator

@wycccccc wycccccc commented Apr 14, 2022

已經在依據新框架rewrite了Smooth Weight #298。故將舊的移除。
保留了Utils,因爲rewrite後有部分還用到,之後再精簡。

@chia7712
Copy link
Contributor

chia7712 commented May 5, 2022

@wycccccc 這隻有機會先合併嗎?

@chia7712
Copy link
Contributor

chia7712 commented May 9, 2022

#315 引入新的dispatcher了,我們除了要討論新的dispatcher的必要性以外,也要回頭看看這隻舊的是不是要砍掉。

@wycccccc
Copy link
Collaborator Author

wycccccc commented May 9, 2022

衝突解決了,上述內容都可以砍掉了。

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wycccccc 先合併這個,然後我們再往前看一下新的

@wycccccc wycccccc merged commit a1b1bb0 into opensource4you:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants