Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fetcher in cost function #354

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

chinghongfang
Copy link
Collaborator

#328
新增cost function fetcher的測試,使用embedded cluster 來檢查,是否有確實抓到我們 "想要的資料"。

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinghongfang 下方那個意見也適用於其他幾個測試,再麻煩看一下

Check the fetched values are what we expected. That is, systemCpuLoad in range [0, 1], memory used < memory max, broker input/output byte = 0.
Check the fetched object's metric name.
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 7093ba9 into opensource4you:main Jun 27, 2022
@chinghongfang chinghongfang deleted the testCostFetcher branch August 3, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants