Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

實作 Admin#preferredLeaderElection #388

Merged

Conversation

garyparrot
Copy link
Collaborator

resolve #386.

@garyparrot garyparrot requested a review from chia7712 June 1, 2022 18:17
@garyparrot garyparrot self-assigned this Jun 1, 2022
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyparrot 感謝修正,有幾個想法請看一下

@garyparrot garyparrot requested a review from chia7712 June 2, 2022 05:08
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyparrot 大致上很棒,不過我還有幾個設計上的想法,請看一下,謝謝

* Now the API can only do one topic/parititon election at a time
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyparrot 感謝更新,剩幾個小疑問請看一下

chia7712
chia7712 previously approved these changes Jun 4, 2022
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyparrot thanks for this great patch. a couple of small comments below. Please merge it if all comments are addressed.

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyparrot garyparrot merged commit 10011ae into opensource4you:main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReplicaMigrator#moveTo(int leader, Set<Integer> follower) 在處理有點規模的 topic 時會出錯
2 participants