Allow ClusterLogAllocation#migrationReplica specify data directory
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jun 23, 2022
app/src/test/java/org/astraea/app/balancer/log/LayeredClusterLogAllocationTest.java
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/balancer/log/ClusterLogAllocation.java
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/balancer/log/ClusterLogAllocation.java
Show resolved
Hide resolved
chia7712
reviewed
Jun 24, 2022
app/src/main/java/org/astraea/app/balancer/log/LayeredClusterLogAllocation.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
延續 #412 (comment)
令
ClusterLogAllocation#migrationReplica能夠指定要搬移到哪個 data directory，同時修改ShufflePlanGenerator的實作，使他能夠使用這個新的 API 來做產生計劃，這樣產生的計劃比較明確，能使後續CostFunction比較好做預測。