Implement post record web api #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandboat
commented
Jun 21, 2022
chia7712
reviewed
Jun 22, 2022
There was a problem hiding this comment.
@brandboat thanks for this patch. a couple of comments below.
|
另外這隻API的文件是要在另外一隻PR完成嗎？ |
chia7712
reviewed
Jun 22, 2022
chia7712
reviewed
Jun 22, 2022
是的，連同 consumer web api 一同完成後，會另開 pr 撰寫 rest api /records 中文文件 |
brandboat
force-pushed
the
feature/implement-web-producer-api
branch
3 times, most recently
from
3ce97e6 to
e31250e
Compare
chia7712
reviewed
Jun 23, 2022
There was a problem hiding this comment.
@brandboat thanks for this patch. a couple of comments below. please take a look.
brandboat
force-pushed
the
feature/implement-web-producer-api
branch
from
e31250e to
6cad402
Compare
brandboat
force-pushed
the
feature/implement-web-producer-api
branch
from
6cad402 to
ed12ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #397