Cache the cluster info to reduce the cost of converting kafka cluster… #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
commented
Jul 9, 2022
| .map(ReplicaInfo::of) | ||
| .flatMap(Collection::stream) | ||
| .collect(Collectors.toUnmodifiableList()); | ||
| if (info.isEmpty()) |
There was a problem hiding this comment.
@qoo332001 @garyparrot 我把這個檢查移除了，因為ClusterBean那端並沒有幫忙做這些檢查，而是讓拿到資料的人自己去做判斷，所以這邊就走一樣的作法，也順便簡化程式碼
|
@chinghongfang 這隻PR合併後，你可否麻煩在實驗室環境中做測試？我這邊有做一個簡單的測試，在叢集中塞入一台狀況不好的機器， BTW，預設的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
兩個重點：
Cluster，因此我們可以透過暫存來避免過多的轉換吃掉頻寬