Change balancer to Use NodeTopicSizeCost to evaluate cost #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
commented
Aug 26, 2022
| * @param allocation offers new host and data folder | ||
| * @return new cluster info | ||
| */ | ||
| public static ClusterInfo update(ClusterInfo clusterInfo, ClusterLogAllocation allocation) { |
There was a problem hiding this comment.
@qoo332001 麻煩看一下，既有的merge產生太多"假資訊"，這會讓cost function很難使用。但我不確定為何你當時填寫這麼多假資訊的目的為何，所以我保留了merge並同時寫了一隻新的方法來產生ClusterInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeTopicSizeCost提供ClusterCostClusterInfo產生方式，盡量保持Replica資訊的完整性Balancer APIs現在改用topic size作為評估手段