fix consumerDone doesn't update #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Sep 7, 2022
| @@ -175,6 +175,9 @@ static TrackerThread create( | |||
| // if producers are not DONE, consumers should keep running as there are more data in | |||
| // the future. | |||
| if (!producerDone) consumerDone = false; | |||
| // if consumers are not DONE, they should keep consuming records when producers were | |||
| // Done. | |||
| if (producerDone && !consumerDone) consumerDone = logConsumers.apply(duration); | |||
There was a problem hiding this comment.
if (!producerDone) producerDone = logProducers.apply(duration);
// if producers are not DONE, consumers should keep running as there are more data in
// the future.
// if consumers are not DONE, they should keep consuming records when producers were
// Done.
if (!producerDone || !consumerDone) consumerDone = logConsumers.apply(duration);麻煩看看這樣是否有更簡化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#680 (comment)
新增 consumerDone 未達100%時，繼續更新消費進度