Fix flaky testCreateTopics #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandboat
force-pushed
the
bugfix/fix-flaky
branch
from
5784be8 to
19c6a3f
Compare
chia7712
reviewed
Sep 19, 2022
| @@ -134,10 +134,20 @@ void testCreateTopics() { | |||
| topicName0, topicName1))); | |||
| var topics = handler.post(request); | |||
| Assertions.assertEquals(2, topics.topics.size()); | |||
There was a problem hiding this comment.
如果確定是 sync 太慢，那這一行應該也是有風險？
There was a problem hiding this comment.
這倒不會，如果沒來得及取得 topic 細節資訊，回傳的資訊僅會包含request 的 topic names
| Assertions.assertEquals(2, t1.partitions.size()); | ||
| // the topic creation is not synced, so we have to wait the creation. | ||
| if (topics.topics.get(0).partitions.isEmpty()) { | ||
| Utils.sleep(Duration.ofSeconds(2)); |
There was a problem hiding this comment.
改成 post 後等待一段時間再使用 admin 撈資料如何？這樣就不用 if-else
There was a problem hiding this comment.
已經更新在最新的 commit 中，感謝審閱
brandboat
force-pushed
the
bugfix/fix-flaky
branch
from
19c6a3f to
b38c6ea
Compare
chia7712
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #722
類似的解法已經有在 testCreateTopicWithReplicas 提供
https://github.com/skiptests/astraea/blob/7596f590ae0f0ec370a6e257c10cc2aeb5fb5bf4/app/src/test/java/org/astraea/app/web/TopicHandlerTest.java#L244-L254