Fix flaky BalancerTest#testLeaderCountRebalance #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Sep 27, 2022
chia7712
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #750
出錯的原因是
SkewedPartitionScenario在把 log 分佈套用到叢集時，只等待一秒鐘當作工作完成，但是實際上這個過程可能會花上不少時間。太快呼叫的結果導致後面重新選舉 leader 時觸發PreferredLeaderNotAvailableException錯誤。修正的方式是用
RebalanceAdmin裏面的等待功能等特定 log 達到 sync 狀態，而非單純等 1 秒鐘。