Add AdminMetrics to expose the status of admin #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
commented
Oct 3, 2022
| @@ -112,18 +108,10 @@ default double ioTimeNsAvg() { | |||
| return (double) beanObject().attributes().get("io-time-ns-avg"); | |||
| } | |||
|
|
|||
| default double iotimeTotal() { | |||
There was a problem hiding this comment.
這幾個都是 deprecated metrics 所以刪除
chia7712
commented
Oct 3, 2022
| @@ -164,6 +164,10 @@ default double reauthenticationLatencyAvg() { | |||
| return (double) beanObject().attributes().get("reauthentication-latency-avg"); | |||
| } | |||
|
|
|||
| default double reauthenticationLatencyMax() { | |||
|
failed test is traced by #815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我們的 web and gui 都仰賴大量的 admin operations，因此需要一個方式來暴露 admin metrics