Erase the chance of concurrent read/write. #82
Merged
+25
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 29, 2021
| @@ -59,6 +59,7 @@ void testBytes() throws InterruptedException { | |||
| getter.start(); | |||
| countDownLatch.countDown(); | |||
| adder.join(); | |||
| getter.join(); | |||
There was a problem hiding this comment.
使用ThreadPool的話會讓這個測試產生"關聯"，也就是說ThreadPool的改動會影響到MetricsTest，想請問這樣是可以接受的嘛？還是用改使用ExecutorService(是java的函式庫)？
There was a problem hiding this comment.
透過使用相同的APIs可以讓整個專案的程式碼風格更一致更好閱讀。
舉個例子，例如你這邊直接用thread、另一邊用Executor，這兩種寫出來的程式碼風格就會截然不同
chia7712
reviewed
Oct 29, 2021
| countDownLatch.countDown(); | ||
| adder.join(); | ||
|
|
||
| ThreadPool threadPool = |
chia7712
reviewed
Oct 29, 2021
| }) | ||
| .build(); | ||
| threadPool.waitAll(); | ||
| threadPool.close(); |
There was a problem hiding this comment.
please use try-with-resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the concurrent read/write in unit test.
Details describe in #76.