astraea-738 Add http client #848

g1geordie · 2022-10-08T15:37:35Z

as title
resolve #738

chia7712

@g1geordie 感謝先處理物件轉換的部分，有幾個建議請看一下

common/src/main/java/org/astraea/common/connector/JsonConverters.java

common/src/main/java/org/astraea/common/connector/HttpExecutorBuilder.java

common/src/main/java/org/astraea/common/connector/URLUtil.java

common/src/main/java/org/astraea/common/connector/HttpExecutor.java

chia7712 · 2022-10-09T18:25:25Z

@g1geordie 可否修正一下衝突？謝謝

…tp-client # Conflicts: # common/src/main/java/org/astraea/common/Utils.java

chia7712

@g1geordie 這隻PR處理的議題比較多，我還有一些想法，不好意思請看一下

common/src/test/java/org/astraea/common/json/JsonConverterTest.java

common/src/main/java/org/astraea/common/connector/HttpExecutor.java

g1geordie · 2022-10-12T16:08:06Z

目前在使用gson 有遇到一個解不了的問題 - 空物件 {} 轉換成 optional
因為 gson 需要有字串 key 的存在才會對那個field 做轉換

所以可能會切換成別的框架像是jackson

    @Override public T read(JsonReader in) throws IOException {
      if (in.peek() == JsonToken.NULL) {
        in.nextNull();
        return null;
      }

      T instance = constructor.construct();

      try {
        in.beginObject();          
        while (in.hasNext()) {
          String name = in.nextName();
          BoundField field = boundFields.get(name);
          if (field == null || !field.deserialized) {
            in.skipValue();
          } else {
            field.read(in, instance);
          }
        }
      } catch (IllegalStateException e) {
        throw new JsonSyntaxException(e);
      } catch (IllegalAccessException e) {
        throw new AssertionError(e);
      }
      in.endObject();
      return instance;
    }

…tp-client # Conflicts: # common/src/main/java/org/astraea/common/Utils.java

chia7712

@g1geordie 感謝實踐這個複雜的功能，有蠻多疑問還請解答

common/src/main/java/org/astraea/common/Utils.java

common/src/main/java/org/astraea/common/http/HttpExecutorBuilder.java

common/src/main/java/org/astraea/common/json/JsonConverter.java

common/src/main/java/org/astraea/common/http/HttpExecutorBuilder.java

common/src/main/java/org/astraea/common/http/HttpExecutor.java

chia7712 · 2022-10-15T21:54:51Z

common/src/main/java/org/astraea/common/http/HttpExecutor.java

+
+  <T> CompletableFuture<HttpResponse<T>> get(String url, Class<T> respCls);
+
+  <T> CompletableFuture<HttpResponse<T>> get(String url, Object param, Class<T> respCls);


param是指 url queries嗎？如果是的話，型別應該可以固定成Map<String, String>

這表示我們不支援 a = v1,v2 的情況嗎

這表示我們不支援 a = v1,v2 的情況嗎

v1,v2 這個應該也可以當成字串吧？還是會有其他隱憂？

了解
缺點大概只有操作api 的人要組出這個字串
將改成 map<String,String>

這樣我們的value 期待是有encode 過的值對嗎

目前暫時讓 Pojo 跟map 都可以放進param 中

將改為只support Map<String,String>
為單一 value 這樣才容易做encode 操作

common/src/main/java/org/astraea/common/http/HttpExecutor.java

common/src/main/java/org/astraea/common/json/JsonConverter.java

chia7712 · 2022-10-18T16:25:57Z

@g1geordie 有一些衝突再麻煩修正

…tp-client # Conflicts: # app/src/main/java/org/astraea/app/scenario/ScenarioMain.java # app/src/main/java/org/astraea/app/web/GroupHandler.java

common/src/main/java/org/astraea/common/json/JsonConverter.java

chia7712 · 2022-10-20T08:15:11Z

@g1geordie 不好意思，可否再修正一下衝突

common/build.gradle

…tp-client # Conflicts: # app/src/main/java/org/astraea/app/web/GroupHandler.java

chia7712

@g1geordie 感謝貢獻，另外我下載這隻PR無法成功建置，

java.lang.AssertionError: isSubtype UNKNOWN
	at jdk.compiler/com.sun.tools.javac.code.Types$4.visitType(Types.java:1123)
	at jdk.compiler/com.sun.tools.javac.code.Types$4.visitType(Types.java:1100)
	at jdk.compiler/com.sun.tools.javac.code.Type.accept(Type.java:214)
	at jdk.compiler/com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4857)
	at jdk.compiler/com.sun.tools.javac.code.Types.isSubtype(Types.java:1096)
	at jdk.compiler/com.sun.tools.javac.code.Types.isSubtypeUncheckedInternal(Types.java:1022)
	at jdk.compiler/com.sun.tools.javac.code.Types.isSubtypeUnchecked(Types.java:1008)
	at jdk.compiler/com.sun.tools.javac.code.Types.isConvertible(Types.java:607)
	at jdk.compiler/com.sun.tools.javac.code.Types.isAssignable(Types.java:2319)
	at jdk.compiler/com.sun.tools.javac.comp.Check$1.compatible(Check.java:522)
	at jdk.compiler/com.sun.tools.javac.comp.Check.checkType(Check.java:563)
	at jdk.compiler/com.sun.tools.javac.comp.Check.checkType(Check.java:550)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.attributeAnnotationValues(Annotate.java:459)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.attributeAnnotation(Annotate.java:415)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.annotateNow(Annotate.java:341)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.lambda$annotateLater$0(Annotate.java:267)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.flush(Annotate.java:191)
	at jdk.compiler/com.sun.tools.javac.comp.Annotate.unblockAnnotations(Annotate.java:144)
	at jdk.compiler/com.sun.tools.javac.comp.TypeEnter.complete(TypeEnter.java:213)
	at jdk.compiler/com.sun.tools.javac.code.Symbol.complete(Symbol.java:642)
	at jdk.compiler/com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1326)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitClassDef(Attr.java:941)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:774)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitAnonymousClassDefinition(Attr.java:2397)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.lambda$visitAnonymousClassDefinition$2(Attr.java:2355)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:265)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:256)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.lambda$min$5(InferenceContext.java:372)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:265)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:256)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.lambda$dupTo$3(InferenceContext.java:332)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:265)
	at jdk.compiler/com.sun.tools.javac.comp.InferenceContext.notifyChange(InferenceContext.java:256)
	at jdk.compiler/com.sun.tools.javac.comp.Infer.instantiateMethod(Infer.java:242)
	at jdk.compiler/com.sun.tools.javac.comp.Resolve.rawInstantiate(Resolve.java:605)
	at jdk.compiler/com.sun.tools.javac.comp.Resolve.checkMethod(Resolve.java:644)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.checkMethod(Attr.java:4122)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.checkIdInternal(Attr.java:3915)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.checkMethodIdInternal(Attr.java:3816)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.checkId(Attr.java:3805)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3698)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2130)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitApply(Attr.java:2006)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1650)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitReturn(Attr.java:1866)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCReturn.accept(JCTree.java:1562)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStats(Attr.java:743)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1294)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitMethodDef(Attr.java:1098)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:866)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClassBody(Attr.java:4685)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClass(Attr.java:4576)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClass(Attr.java:4505)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitClassDef(Attr.java:951)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:774)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitAnonymousClassDefinition(Attr.java:2397)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitNewClass(Attr.java:2288)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCNewClass.accept(JCTree.java:1705)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitReturn(Attr.java:1866)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCReturn.accept(JCTree.java:1562)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStats(Attr.java:743)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1294)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1036)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.visitMethodDef(Attr.java:1098)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:866)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribTree(Attr.java:655)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribStat(Attr.java:724)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClassBody(Attr.java:4685)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClass(Attr.java:4576)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attribClass(Attr.java:4505)
	at jdk.compiler/com.sun.tools.javac.comp.Attr.attrib(Attr.java:4450)
	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.attribute(JavaCompiler.java:1337)
	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
	at org.gradle.internal.compiler.java.IncrementalCompileTask.call(IncrementalCompileTask.java:89)
	at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:94)
	at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:54)
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:39)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:97)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:51)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:37)
	at org.gradle.api.internal.tasks.compile.AnnotationProcessorDiscoveringCompiler.execute(AnnotationProcessorDiscoveringCompiler.java:51)
	at org.gradle.api.internal.tasks.compile.AnnotationProcessorDiscoveringCompiler.execute(AnnotationProcessorDiscoveringCompiler.java:37)
	at org.gradle.api.internal.tasks.compile.ModuleApplicationNameWritingCompiler.execute(ModuleApplicationNameWritingCompiler.java:46)
	at org.gradle.api.internal.tasks.compile.ModuleApplicationNameWritingCompiler.execute(ModuleApplicationNameWritingCompiler.java:36)
	at org.gradle.jvm.toolchain.internal.DefaultToolchainJavaCompiler.execute(DefaultToolchainJavaCompiler.java:57)
	at org.gradle.api.tasks.compile.JavaCompile.lambda$createToolchainCompiler$1(JavaCompile.java:232)
	at org.gradle.api.internal.tasks.compile.CleaningJavaCompiler.execute(CleaningJavaCompiler.java:53)
	at org.gradle.api.internal.tasks.compile.incremental.IncrementalCompilerFactory.lambda$createRebuildAllCompiler$0(IncrementalCompilerFactory.java:52)
	at org.gradle.api.internal.tasks.compile.incremental.SelectiveCompiler.execute(SelectiveCompiler.java:67)
	at org.gradle.api.internal.tasks.compile.incremental.SelectiveCompiler.execute(SelectiveCompiler.java:41)
	at org.gradle.api.internal.tasks.compile.incremental.IncrementalResultStoringCompiler.execute(IncrementalResultStoringCompiler.java:66)
	at org.gradle.api.internal.tasks.compile.incremental.IncrementalResultStoringCompiler.execute(IncrementalResultStoringCompiler.java:52)
	at org.gradle.api.internal.tasks.compile.CompileJavaBuildOperationReportingCompiler$2.call(CompileJavaBuildOperationReportingCompiler.java:59)
	at org.gradle.api.internal.tasks.compile.CompileJavaBuildOperationReportingCompiler$2.call(CompileJavaBuildOperationReportingCompiler.java:51)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.api.internal.tasks.compile.CompileJavaBuildOperationReportingCompiler.execute(CompileJavaBuildOperationReportingCompiler.java:51)
	at org.gradle.api.tasks.compile.JavaCompile.performCompilation(JavaCompile.java:279)
	at org.gradle.api.tasks.compile.JavaCompile.performIncrementalCompilation(JavaCompile.java:165)
	at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:146)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
	at org.gradle.api.internal.project.taskfactory.IncrementalInputsTaskAction.doExecute(IncrementalInputsTaskAction.java:32)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
	at org.gradle.api.internal.project.taskfactory.AbstractIncrementalTaskAction.execute(AbstractIncrementalTaskAction.java:25)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
	at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:236)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:68)
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:221)
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:204)
	at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.java:187)
	at org.gradle.api.internal.tasks.execution.TaskExecution.execute(TaskExecution.java:165)
	at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:89)
	at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:40)
	at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:53)
	at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:50)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:50)
	at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:40)
	at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:68)
	at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:38)
	at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:41)
	at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:74)
	at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55)
	at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:51)
	at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:29)
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.executeDelegateBroadcastingChanges(CaptureStateAfterExecutionStep.java:124)
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:80)
	at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:58)
	at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:48)
	at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:36)
	at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:181)
	at org.gradle.internal.execution.steps.BuildCacheStep.lambda$execute$1(BuildCacheStep.java:71)
	at org.gradle.internal.Either$Right.fold(Either.java:175)
	at org.gradle.internal.execution.caching.CachingState.fold(CachingState.java:59)
	at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:69)
	at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:47)
	at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:36)
	at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:25)
	at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:36)
	at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:22)
	at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:110)
	at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$2(SkipUpToDateStep.java:56)
	at java.base/java.util.Optional.orElseGet(Optional.java:369)
	at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:56)
	at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:38)
	at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:73)
	at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:44)
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37)
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27)
	at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:89)
	at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:50)
	at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:114)
	at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:57)
	at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:76)
	at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:50)
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.executeWithNoEmptySources(SkipEmptyWorkStep.java:254)
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.executeWithNoEmptySources(SkipEmptyWorkStep.java:209)
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:88)
	at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:56)
	at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:32)
	at org.gradle.internal.execution.steps.RemoveUntrackedExecutionStateStep.execute(RemoveUntrackedExecutionStateStep.java:21)
	at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)
	at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:43)
	at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:31)
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.lambda$execute$0(AssignWorkspaceStep.java:40)
	at org.gradle.api.internal.tasks.execution.TaskExecution$4.withWorkspace(TaskExecution.java:281)
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:40)
	at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:30)
	at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:37)
	at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:27)
	at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:44)
	at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:33)
	at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:76)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:139)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:128)
	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:77)
	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
	at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:69)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:327)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:314)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:307)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:293)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:420)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:342)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

app/src/main/java/org/astraea/app/web/ThrottleHandler.java

app/src/main/java/org/astraea/app/web/PostRequest.java

common/src/main/java/org/astraea/common/http/HttpExecutor.java

common/src/main/java/org/astraea/common/json/TypeRef.java

common/src/main/java/org/astraea/common/http/AstraeaHttpResponse.java

g1geordie · 2022-10-24T00:30:24Z

@chia7712 PTAL

chia7712

@g1geordie 感謝你處理這個複雜的功能，還有幾個建議請看一下

另外也請將一些即將要被刪掉的class標上deprecated，這樣方便我們後續追蹤

chia7712 · 2022-10-24T01:14:50Z

app/src/main/java/org/astraea/app/web/PostRequest.java

  static PostRequest of(String json) {
-    return of((Map<String, Object>) new Gson().fromJson(json, Map.class));
+    return of(
+        JsonConverter.defaultConverter().<Map<String, Object>>fromJson(json, new TypeRef<>() {}));


請問能否用TypeRef.map取代？

chia7712 · 2022-10-24T01:17:04Z

common/src/main/java/org/astraea/common/json/JsonConverter.java

+  /** for nested generic object ,the return value should specify typeRef , Example: List<String> */
+  <T> T fromJson(String json, TypeRef<T> typeRef);
+
+  static JsonConverter defaultConverter() {


這邊是要等下一隻PR才來改成jackson嗎？

沒錯因為他需要複寫所有response的default constructor
#974

chia7712 · 2022-10-24T01:23:50Z

common/src/main/java/org/astraea/common/http/Response.java

+    this.completionStage = completionStage;
+  }
+
+  public CompletionStage<HttpResponse<T>> completionStage() {


這邊的用法變成Response又回傳一個HttpResponse，使用者變成要拆兩次包裹，如果整個Response的內容都是非同步的話，我們應該讓Response本身帶有“全部已經完成的資訊”，然後HttpExecutor改成回傳CompletionStage<Response>，這樣改有兩個好處，第一個是簡化資料結構，不需要包兩層Response，另一個則是方便之後串接async，可以直接寫executor.get(xx).thenCompose(r -> xx) 取代 executor.get(xx).completionStage.thenCompose(r -> xxx

@chia7712 可以幫我看一下是不是你想要的形式嗎

chia7712 · 2022-10-24T16:18:41Z

app/src/main/java/org/astraea/app/web/PostRequest.java

+  default <T> List<T> valuesWithDefault(String key, Class<T> clz) {
+    try {
+      return values(key, clz);
+    } catch (NoSuchElementException noSuchElementException) {


所以是讓下列兩種 body 等價嗎？

{ "a":[] }

{ }

如果是的話，這個概念不錯，處理 empty 比處理 null 直覺，不過這個可能會牽扯到 docs 的修改，可否另外開一隻PR處理？另外也要驗證下方 body 是否也等價：

{ "a":null }

主要是因為在ThrottleHandler 中呼叫 values 的人
沒有期待exception 會丟出

將會先把try catch 加在ThrottleHandler 中

主要是因為在ThrottleHandler 中呼叫 values 的人

所以是原本就有預期 Null == empty 嗎？如果是的話，那就先用目前的手法也可以

原本沒有帶值的時候會給空陣列

common/src/main/java/org/astraea/common/http/Response.java

chia7712 · 2022-10-24T20:06:06Z

app/src/main/java/org/astraea/app/web/GroupHandler.java

    final String clientId;
    final String host;
    final List<OffsetProgress> offsetProgress;

+    private Member() {


為何這邊特別寫了default constructor?

因為 gson 可以反序列化物件但當json 中沒有值的時候會跟jackson 一樣optional 會為null
#974 這裡有比較詳細的說明

那為何只有這個物件特別加上去？其他物件沒有相同困擾嗎

chia7712 · 2022-10-24T20:08:08Z

app/src/main/java/org/astraea/app/web/ThrottleHandler.java

-                TypeToken.getParameterized(Collection.class, TopicThrottle.class).getType())
-            .orElse(List.of());
+        withDefault(() -> channel.request().values("brokers", BrokerThrottle.class));
+    var topics = withDefault(() -> channel.request().values("topics", TopicThrottle.class));


這裡我的疑惑是現在get這個方法依然是回傳Optional，那麼當對應key值不存在時，應該會回傳Optional.empty，換言之，這邊應該是不用跟著修改才對？

這邊是你之前的comment
希望可以用values 來取代 getList 這件事情

這邊是你之前的comment
希望可以用values 來取代 getList 這件事情

應該是我有點忘了，不過整體來說，如果 handler request更換到 Jackson 要再另外一隻PR處理的話，這部分就跟著等到那隻PR在弄，因為等移動到jackson後， request的介面應該可以好好整修一下，至少可以改成用TypeRef來簡化很多轉換

了解大部分明顯的轉換都已經用 TypeRef了
這樣我這裡要先把他們移除掉嗎

是的，麻煩一下，不然我怕其他也在改 handler 的人會討厭這隻PR

了解
將把app module底下的converter轉換移除

…tp-client

chia7712

@g1geordie 感謝處理這個麻煩的功能，目前看起來很好，我會先合併，後續的議題再麻煩幫忙

g1geordie added 2 commits October 8, 2022 23:35

astraea-738 Add http client

354b7df

ref to this

6869025

chia7712 reviewed Oct 8, 2022

View reviewed changes

g1geordie added 2 commits October 10, 2022 00:51

fix comment

a7267ce

convert2Uri

6d475d4

Merge remote-tracking branch 'skiptests/main' into astraea-738-add-ht…

7d81ca7

…tp-client # Conflicts: # common/src/main/java/org/astraea/common/Utils.java

chia7712 reviewed Oct 10, 2022

View reviewed changes

common/src/main/java/org/astraea/common/connector/HttpExecutor.java Outdated Show resolved Hide resolved

chia7712 mentioned this pull request Oct 11, 2022

Introduce jdbc connector #870

Closed

g1geordie mentioned this pull request Oct 12, 2022

Add default urls in http client #887

Open

g1geordie added 4 commits October 16, 2022 03:38

fix comment

c95852b

Merge remote-tracking branch 'skiptests/main' into astraea-738-add-ht…

8cd2ef9

…tp-client # Conflicts: # common/src/main/java/org/astraea/common/Utils.java

fix import

a29d1ee

remove unused dependency

dd44bfd

chia7712 reviewed Oct 15, 2022

View reviewed changes

g1geordie added 4 commits October 16, 2022 18:14

fix comment

8b7e2b7

add opt test

1bb6627

add typeRef test

07cceb3

remove desc

f4e17a9

chia7712 reviewed Oct 17, 2022

View reviewed changes

common/src/main/java/org/astraea/common/json/JsonConverter.java Outdated Show resolved Hide resolved

g1geordie added 2 commits October 18, 2022 01:48

test

cf9e770

test

564d186

g1geordie added 3 commits October 19, 2022 00:26

Merge remote-tracking branch 'skiptests/main' into astraea-738-add-ht…

62b9ef0

…tp-client # Conflicts: # app/src/main/java/org/astraea/app/scenario/ScenarioMain.java # app/src/main/java/org/astraea/app/web/GroupHandler.java

merge main

faf2382

add diamond

593aecd

chia7712 reviewed Oct 19, 2022

View reviewed changes

common/src/main/java/org/astraea/common/json/JsonConverter.java Outdated Show resolved Hide resolved

chia7712 mentioned this pull request Oct 19, 2022

Replace AdoptOpenJDK by zulu for CI #962

Merged

format code

0a48b21

chia7712 reviewed Oct 20, 2022

View reviewed changes

common/build.gradle Show resolved Hide resolved

g1geordie added 4 commits October 20, 2022 21:31

Merge remote-tracking branch 'skiptests/main' into astraea-738-add-ht…

29096ad

…tp-client # Conflicts: # app/src/main/java/org/astraea/app/web/GroupHandler.java

private

2aca78b

typo

4791174

fix json typo

b52ef26

g1geordie mentioned this pull request Oct 20, 2022

Replace gson with jackson #974

Closed