Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Metric Explorer #86

Merged
merged 14 commits into from
Nov 11, 2021

Conversation

garyparrot
Copy link
Collaborator

@garyparrot garyparrot commented Nov 1, 2021

Context: #10

This PR implements a tool to fetch raw Mbean metrics from a JMX server.

List Mbeans' metrics

./gradlew run --args="metrics --jmx.server localhost:11111"

https://gist.github.com/garyparrot/f13d858fe47b7da8cffa0b31d0ee90f6

List Mbeans' object name

./gradlew run --args="metrics --jmx.server localhost:11111 --view-object-name-list"

https://gist.github.com/garyparrot/bfae020adf9d4f969ef4d4444078dd2c

TODO

  • Update README.md
  • Add unit tests.
  • in README.d, Metric Client -> Metric Explorer
  • update demo

@garyparrot garyparrot marked this pull request as ready for review November 9, 2021 16:16
@garyparrot garyparrot changed the title [WIP] Implementation of Metric Explorer Implementation of Metric Explorer Nov 9, 2021
@garyparrot garyparrot requested a review from chia7712 November 9, 2021 16:16
Some hard limit has been apply to the DataUtil#elaborate* series
function. This commit remove them.
1. Some Mbeans from the JVM contain extremely long string, this commit
   implement some code to truncated those string.
2. Some Mbeans will throwing error during access, this commit wrap all
   the DataUtil#* routine with a try-catch block.
3. remove hard limit on collection output size.
@chia7712 chia7712 merged commit 04c1999 into opensource4you:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants