Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed tests in MetadataTest #872

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix failed tests in MetadataTest #872

merged 1 commit into from
Oct 11, 2022

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Oct 11, 2022 •
edited
Loading

修正錯誤測試，目前 ci 會因為 defaultTest, configuredTest 這兩個測試報錯

@brandboat brandboat changed the title Fix failed test in MetadataTest Fix failed tests in MetadataTest Oct 11, 2022
@brandboat
Copy link
Member Author

AC, gentle ping @chia7712 @wycccccc

@wycccccc wycccccc self-requested a review October 11, 2022 09:21
@wycccccc
Copy link
Collaborator

sry, 應該是我resolve conflict的時候沒處理好,LGTM。

@wycccccc wycccccc merged commit b37714f into opensource4you:main Oct 11, 2022
@brandboat brandboat deleted the bugfix/fix-Metadatatest branch October 11, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wycccccc wycccccc wycccccc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandboat @wycccccc