Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for AsyncAdmin #913

Merged

Conversation

chaohengstudent
Copy link
Collaborator

#837
add test in AsyncAdminTest

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaohengstudent 感謝補上測試,看起來很棒,只有一個建議請看一下

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please merge it if QA pass

chia7712
chia7712 previously approved these changes Oct 15, 2022
@chia7712
Copy link
Contributor

@chaohengstudent 抱歉,我不小心造成了衝突,還請幫忙處理一下

# Conflicts:
#	common/src/test/java/org/astraea/common/admin/AsyncAdminTest.java
@chia7712
Copy link
Contributor

I will merge it after QA passes

@chia7712 chia7712 merged commit ce1e1de into opensource4you:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants